1
# TypeScript review pass
2
3
Run over the diff before calling a change done. Each item is a question with a yes or
4
no answer.
5
6
## Types
7
8
- [ ] Any new `any`? Is `unknown` plus narrowing possible instead?
9
- [ ] Any new `!` or `as`? What guarantees it, and is that guarantee in the type system?
10
- [ ] Does every new function's return type cover the undefined and error paths?
11
- [ ] Is external data validated at the boundary rather than cast?
12
13
## Errors
14
15
- [ ] Any empty catch, or catch that only logs? Is that deliberate and explained?
16
- [ ] Does any error path swallow the cause?
17
- [ ] Can a caller distinguish "no result" from "failed to look"?
18
19
## Structure
20
21
- [ ] Is any new abstraction used more than once?
22
- [ ] Any new exported symbol that only the module itself uses?
23
- [ ] Does the new code read like the file around it?
24
25
## Async
26
27
- [ ] Any unawaited promise? Deliberate?
28
- [ ] Any sequential await over independent calls?
29
30
## Tests
31
32
- [ ] Does a new test fail if the change is reverted? If not, it is not testing the change.
33
- [ ] Is the error path tested, not just the happy path?
34